Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Curl redirect on get #331

Merged
merged 2 commits into from
Mar 14, 2023
Merged

Allow Curl redirect on get #331

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e7d597
Allow CURL redirects on GET requests
Mar 3, 2023
dc8773f
Support redirects for more than just GET
nkoenig Mar 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/RestClient.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,11 @@ RestResponse Rest::Request(HttpMethod _method,
// Send the request.
if (_method == HttpMethod::GET)
{
// no need to do anything
// Follow redirects to any URL set on the Location header.
curl_easy_setopt(curl, CURLOPT_FOLLOWLOCATION, 1L);

// Set cURL to only follow 3 redirects tops.
curl_easy_setopt(curl, CURLOPT_MAXREDIRS, 3L);
nkoenig marked this conversation as resolved.
Show resolved Hide resolved
}
else if (_method == HttpMethod::PATCH_FORM)
{
Expand Down