Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 ➡️ 4 #72

Merged
merged 9 commits into from
Jun 5, 2020
Merged

3 ➡️ 4 #72

merged 9 commits into from
Jun 5, 2020

Conversation

chapulina
Copy link
Contributor

Primarily a forward-port of #70 , but it also syncs other commits.

claireyywang and others added 9 commits April 18, 2020 10:53
Signed-off-by: claireyywang <[email protected]>
Signed-off-by: claireyywang <[email protected]>
* [ign-fuel-tools3] Update BitBucket links

Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Co-authored-by: Louise Poubel <[email protected]>
Co-authored-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina requested a review from nkoenig May 19, 2020 16:40
@chapulina chapulina self-assigned this May 19, 2020
@github-actions github-actions bot added 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels May 19, 2020
@codecov
Copy link

codecov bot commented May 19, 2020

Codecov Report

Merging #72 into ign-fuel-tools4 will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           ign-fuel-tools4      #72      +/-   ##
===================================================
+ Coverage            78.48%   78.50%   +0.01%     
===================================================
  Files                   16       16              
  Lines                 2212     2214       +2     
===================================================
+ Hits                  1736     1738       +2     
  Misses                 476      476              
Impacted Files Coverage Δ
src/RestClient.cc 60.16% <100.00%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c12f929...2b372a1. Read the comment docs.

@chapulina
Copy link
Contributor Author

I think the Ubuntu failure was due to some infra issue. Retriggered: Build Status

@chapulina
Copy link
Contributor Author

closing and reopening to retrigger CI

@chapulina chapulina closed this May 21, 2020
@chapulina chapulina reopened this May 21, 2020
@chapulina chapulina mentioned this pull request May 26, 2020
@chapulina chapulina merged commit 0ded4bf into ign-fuel-tools4 Jun 5, 2020
@chapulina chapulina deleted the 3_to_4 branch June 5, 2020 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants