Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumps in garden : ign-garden #4

Merged
merged 3 commits into from
Nov 20, 2021
Merged

Bumps in garden : ign-garden #4

merged 3 commits into from
Nov 20, 2021

Conversation

scpeters
Copy link
Member

@scpeters
Bumps in garden : ign-garden
6cd0370 
Signed-off-by: Steve Peters <[email protected]>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Nov 19, 2021
@scpeters scpeters mentioned this pull request Nov 19, 2021
Merged
chapulina
chapulina approved these changes Nov 20, 2021
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@chapulina
Copy link
Contributor

btw, CI won't fail until #2 is merged

@chapulina
Copy link
Contributor

-- Looking for ignition-rendering7 - not found

@scpeters
Copy link
Member Author

-- Looking for ignition-rendering7 - not found

  CMake Warning at /usr/share/cmake/ignition-cmake2/cmake2/IgnUtils.cmake:189 (find_package):
    Could not find a configuration file for package "ignition-rendering7" that
    is compatible with requested version "6.0.1".

thanks for the cmake check; that is finding an error, but I am confused as to where it is coming from

@scpeters
Copy link
Member Author

-- Looking for ignition-rendering7 - not found

  CMake Warning at /usr/share/cmake/ignition-cmake2/cmake2/IgnUtils.cmake:189 (find_package):
    Could not find a configuration file for package "ignition-rendering7" that
    is compatible with requested version "6.0.1".

thanks for the cmake check; that is finding an error, but I am confused as to where it is coming from

ha nevermind

@scpeters scpeters merged commit 801aee6 into main Nov 20, 2021
@scpeters scpeters deleted the bump_garden_ign-garden branch November 20, 2021 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@adlarkin adlarkin Awaiting requested review from adlarkin

Assignees
No one assigned
Labels
🌱 garden Ignition Garden
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scpeters @chapulina