Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge Image Display UpdateFrom* functions. #177

Closed
iche033 opened this issue Feb 8, 2021 · 1 comment · Fixed by #212
Closed

Merge Image Display UpdateFrom* functions. #177

iche033 opened this issue Feb 8, 2021 · 1 comment · Fixed by #212
Assignees
@adlarkin
Labels
enhancement New feature or request

Comments

@iche033
Copy link
Contributor

iche033 commented Feb 8, 2021

Desired behavior

There is quite a bit of duplicate code in the various UpdateFrom* functions in Image Display. Let's try to keep the same Image Display behavior and functionality but with some refactoring underneath the hood.

Implementation suggestion

Merge the UpdateFrom* function. We could templates or just refactor out the code from converting an image array of the input type (int8, int16, float32) to an rgb image buffer:
https://github.com/ignitionrobotics/ign-gui/blob/ign-gui4/src/plugins/image_display/ImageDisplay.cc#L261-L280

Additional context

related pull request comment
@iche033 iche033 added the enhancement New feature or request label Feb 8, 2021
@iche033 iche033 mentioned this issue Feb 8, 2021
Merged
6 tasks
@adlarkin adlarkin self-assigned this Feb 8, 2021
@adlarkin adlarkin mentioned this issue May 5, 2021
Merged
8 tasks
@adlarkin adlarkin linked a pull request May 5, 2021 that will close this issue
Refactor Image Display to use ConvertToRGB function #212
Merged
8 tasks
@adlarkin
Copy link
Contributor

adlarkin commented Jul 6, 2021

I'm closing this since #212 has been merged.

@adlarkin adlarkin closed this as completed Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adlarkin adlarkin

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor Image Display to use ConvertToRGB function gazebosim/gz-gui
2 participants
@iche033 @adlarkin