-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visualize single channel 8 bit image data #176
Conversation
Signed-off-by: Ian Chen <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-gui4 #176 +/- ##
============================================
- Coverage 61.57% 60.77% -0.81%
============================================
Files 21 21
Lines 2803 2840 +37
============================================
Hits 1726 1726
- Misses 1077 1114 +37
Continue to review full report at Codecov.
|
Signed-off-by: Ian Chen <[email protected]>
I think this is good to go - do we need to add some sort of test? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there are currently no tests for pixel formats with image display (https://github.com/ignitionrobotics/ign-gui/blob/a60cb7d61339b407ff3285ddbf16f618c4c4b3b9/src/plugins/image_display/ImageDisplay_TEST.cc), I think that this is fine as is. Perhaps we can add some tests later if people think that would be a worthwhile contribution.
Signed-off-by: Ian Chen [email protected]
Summary
Extended Image Display plugin to support visualizing single channel 8 bit unsigned integer data in a similar way to the 16 bit data. This is used by gazebosim/gz-sim#614 to visualize 8 bit thermal image data (see PR for screenshot)
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge