Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3 ➡️ 4 #152

Merged
merged 5 commits into from
Dec 16, 2020
Merged

3 ➡️ 4 #152

merged 5 commits into from
Dec 16, 2020

Conversation

chapulina
Copy link
Contributor

Forward-port ign-gui3 to ign-gui4

@chapulina
Add gazebo gui events (#148)
322f872 
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>

Co-authored-by: Louise Poubel <[email protected]>
@chapulina chapulina requested a review from JShep1 December 10, 2020 20:44
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Dec 10, 2020
@codecov
Copy link

codecov bot commented Dec 10, 2020 •
edited
Loading

Codecov Report

Merging #152 (def5df4) into ign-gui4 (19f9dae) will increase coverage by 0.65%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-gui4     #152      +/-   ##
============================================
+ Coverage     60.92%   61.57%   +0.65%     
============================================
  Files            21       21              
  Lines          2751     2790      +39     
============================================
+ Hits           1676     1718      +42     
+ Misses         1075     1072       -3
Impacted Files Coverage Δ
include/ignition/gui/GuiEvents.hh 100.00% <100.00%> (+100.00%) ⬆️
src/Conversions.cc 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19f9dae...def5df4. Read the comment docs.

chapulina and others added 3 commits December 10, 2020 13:21
@JShep1
Copy link

JShep1 commented Dec 15, 2020

Friendly ping to bring in changes from #153 and #154

@chapulina
3 to 4
def5df4 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
Copy link
Contributor Author

PR updated!

JShep1
JShep1 approved these changes Dec 16, 2020
View reviewed changes
Copy link

@JShep1 JShep1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't suspect these changes should make CI fail, but there are about half of the checks failing. It doesn't look like this PR introduces any regressions, but it looks like some of the tests didn't run: No test results found? Perhaps we should re-run CI?

@chapulina chapulina merged commit 1c1d53f into ign-gui4 Dec 16, 2020
@chapulina chapulina deleted the chapulina/3_to_4 branch December 16, 2020 19:42
@adlarkin adlarkin mentioned this pull request Dec 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JShep1 JShep1 JShep1 approved these changes

Assignees
No one assigned
Labels
🔮 dome Ignition Dome
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chapulina @JShep1