-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new GuiEvent HoverOnScene #273
Conversation
Signed-off-by: ahcorde <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #273 +/- ##
==========================================
+ Coverage 64.79% 65.14% +0.35%
==========================================
Files 32 32
Lines 4508 4525 +17
==========================================
+ Hits 2921 2948 +27
+ Misses 1587 1577 -10
Continue to review full report at Codecov.
|
public: explicit HoverOnScene(const math::Vector2i &_point); | ||
|
||
/// \brief Unique type for this event. | ||
static const QEvent::Type kType = QEvent::Type(QEvent::MaxUser - 13); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noob question, why -13
? Can this be documented in the comments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea to comment it, because it keeps coming up 😅
tl;dr: gazebo::gui:GuiEvents
count up, gui::GuiEvents
count down.
See context here: #70 (comment)
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde [email protected]
🎉 New feature
Summary
It publishes the onhover mouse 2D points
Required by:
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge