-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3 ➡️ 4 #279
3 ➡️ 4 #279
Conversation
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Jenn Nguyen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with happy CI
Codecov Report
@@ Coverage Diff @@
## ign-gui4 #279 +/- ##
=========================================
Coverage 66.39% 66.39%
=========================================
Files 26 26
Lines 3205 3205
=========================================
Hits 2128 2128
Misses 1077 1077 Continue to review full report at Codecov.
|
Failed tests appear to be flaky. Can I go ahead and merge this @chapulina ? |
Yup, go for it! |
➡️ Forward port
Port
ign-gui3
toign-gui4
Branch comparison: ign-gui4...ign-gui3
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)