Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 ➡️ 4 #279

Merged
merged 4 commits into from
Sep 8, 2021
Merged

3 ➡️ 4 #279

merged 4 commits into from
Sep 8, 2021

Conversation

jennuine
Copy link
Contributor

@jennuine jennuine commented Sep 8, 2021

➡️ Forward port

Port ign-gui3 to ign-gui4

Branch comparison: ign-gui4...ign-gui3

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

chapulina and others added 4 commits August 3, 2021 17:13
@jennuine jennuine requested a review from chapulina as a code owner September 8, 2021 16:46
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Sep 8, 2021
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with happy CI

@chapulina chapulina added the beta Targeting beta release of upcoming collection label Sep 8, 2021
@codecov
Copy link

codecov bot commented Sep 8, 2021

Codecov Report

Merging #279 (9700554) into ign-gui4 (10f94f0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           ign-gui4     #279   +/-   ##
=========================================
  Coverage     66.39%   66.39%           
=========================================
  Files            26       26           
  Lines          3205     3205           
=========================================
  Hits           2128     2128           
  Misses         1077     1077           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10f94f0...9700554. Read the comment docs.

@jennuine
Copy link
Contributor Author

jennuine commented Sep 8, 2021

Failed tests appear to be flaky. Can I go ahead and merge this @chapulina ?

@chapulina
Copy link
Contributor

Yup, go for it!

@jennuine jennuine merged commit 33edc9e into ign-gui4 Sep 8, 2021
@jennuine jennuine deleted the jennuine/3_to_4 branch September 8, 2021 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants