3 ➡️ 4 #328
Merged
3 ➡️ 4 #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikhil Nair <[email protected]> Signed-off-by: Louise Poubel <[email protected]> Co-authored-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
- Change binding of width property in delegate (see: https://stackoverflow.com/questions/63767669/parent-is-null-in-listview-delegate-after-upgrade-to-qt-5-15) - Use scoped reference to model.display (see: https://forum.qt.io/topic/92085/using-qstringlistmodel-as-model-in-listview) Signed-off-by: Rhys Mainwaring <[email protected]>
Signed-off-by: William Wedler <[email protected]> Co-authored-by: Louise Poubel <[email protected]>
jennuine
reviewed
Dec 6, 2021
Ah my bad, see #329
Codecheck is only enabled on Bionic, because it's hard to satisfy multiple versions of cppcheck at the same time. We've recently added an option to enable it for Focal though: gazebo-tooling/action-gz-ci#43 |
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
chapulina
force-pushed
the
chapulina/3_to_4
branch
from
be6ddae to
c2bdfff
Compare
Codecov Report
@@ Coverage Diff @@
## ign-gui4 #328 +/- ##
============================================
+ Coverage 66.37% 66.71% +0.34%
============================================
Files 26 26
Lines 3206 3221 +15
============================================
+ Hits 2128 2149 +21
+ Misses 1078 1072 -6
Continue to review full report at Codecov.
|
ahcorde
approved these changes
Dec 6, 2021
jennuine
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port
ign-gui3toign-gui4Branch comparison: ign-gui4...ign-gui3
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)