-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace pose in Grid3d with GzPose #461
Conversation
Signed-off-by: youhy <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-gui3 #461 +/- ##
=========================================
Coverage 69.81% 69.81%
=========================================
Files 29 29
Lines 3273 3273
=========================================
Hits 2285 2285
Misses 988 988 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use the IgnHelpers.getDecimals
:
gz-gui/src/plugins/grid_3d/Grid3D.qml
Lines 33 to 41 in 451146b
// Get number of decimal digits based on a widget's width | |
// TODO(chapulina) Move this to a common place so all widgets can use it | |
function getDecimals(_width) { | |
if (_width <= 80) | |
return 2; | |
else if (_width <= 100) | |
return 4; | |
return 6; | |
} |
Signed-off-by: youhy <[email protected]>
Signed-off-by: youhy [email protected]
New feature
Summary
As title. The behavior should be exactly the same as before.
Test it
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.