Add key publisher test #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jenn Nguyen <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-gui3 #477 +/- ##
============================================
+ Coverage 73.51% 73.82% +0.30%
============================================
Files 30 30
Lines 3270 3270
============================================
+ Hits 2404 2414 +10
+ Misses 866 856 -10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ahcorde
approved these changes
Aug 25, 2022
|
@ahcorde what's the minor comment? |
ahcorde
requested changes
Aug 25, 2022
Comment on lines
+110
to
+124
| protected: Application app{g_argc, g_argv}; | ||
|
|
||
| // Instance of the main window. | ||
| protected: MainWindow *win; | ||
|
|
||
| // List of plugins. | ||
| protected: QList<KeyPublisher *> plugins; | ||
| protected: KeyPublisher *plugin; | ||
|
|
||
| // Checks if a new key has been received. | ||
| protected: bool received = false; | ||
| protected: transport::Node node; | ||
|
|
||
| // Current key | ||
| protected: int currentKey = 0; |
There was a problem hiding this comment.
private instead of protected ?
There was a problem hiding this comment.
If private then the members won't be accessible, specifically we can't call:
gz-gui/src/plugins/key_publisher/KeyPublisher_TEST.cc
Lines 130 to 132 in c8d3d62
ahcorde
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of gazebosim/gz-sim#1575
Summary
Added
KeyPublisher_TESTto increase code coverageChecklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.