-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cmd/CMakeLists to conform with all other gz libraries #478
Conversation
This fixes the library path obtained by cmdgui.rb such that it points to the .so file contained in the non-dev debian package. Signed-off-by: Addisu Z. Taddese <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ign_TEST
is failing
/github/workspace/src/ign_TEST.cc:98: Failure
Expected: (output.find("TopicEcho")) != (std::string::npos), actual: 18446744073709551615 vs 18446744073709551615
Library error: [/github/workspace/lib/libignition-gui3.so.3.11.2] not found.
/github/workspace/src/ign_TEST.cc:99: Failure
Expected: (output.find("Publisher")) != (std::string::npos), actual: 18[4467](https://github.com/gazebosim/gz-gui/runs/8026238453?check_suite_focus=true#step:4:4475)44073709551615 vs 18446744073709551615
Library error: [/github/workspace/lib/libignition-gui3.so.3.11.2] not found.
Signed-off-by: Addisu Z. Taddese <[email protected]>
Fixed failing test in 4c33a15. I missed the corresponding changes in |
Codecov Report
@@ Coverage Diff @@
## ign-gui3 #478 +/- ##
=========================================
Coverage 73.51% 73.51%
=========================================
Files 30 30
Lines 3270 3270
=========================================
Hits 2404 2404
Misses 866 866 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Windows isn't happy `` C:/Jenkins/workspace/ign_gui-pr-win/ws/build/ignition-gui3/test/lib/ruby/ignition/cmdgui3.rb
|
UNIT_ign_TEST was disabled on windows anyway. In addition, this follows the pattern in ign-transport and ign-msgs. Signed-off-by: Addisu Z. Taddese <[email protected]>
I disabled the cmake generation for |
|
This fixes the library path obtained by cmdgui.rb such that it points to the .so file contained in the non-dev debian pack Signed-off-by: Addisu Z. Taddese <[email protected]>
…im#478) This fixes the library path obtained by cmdgui.rb such that it points to the .so file contained in the non-dev debian pack Signed-off-by: Addisu Z. Taddese <[email protected]>
…im#478) This fixes the library path obtained by cmdgui.rb such that it points to the .so file contained in the non-dev debian pack Signed-off-by: Addisu Z. Taddese <[email protected]>
…480) This fixes the library path obtained by cmdgui.rb such that it points to the .so file contained in the non-dev debian pack Signed-off-by: Addisu Z. Taddese <[email protected]> Signed-off-by: Louise Poubel <[email protected]> Co-authored-by: Louise Poubel <[email protected]> Co-authored-by: Jenn Nguyen <[email protected]>
🦟 Bug fix
Summary
The updated cmake file is now similar to other gz libraries, eg. https://github.com/gazebosim/gz-transport/blob/9ba73b74f6ba9717d33429ebf93ef1500c7958f4/src/cmd/CMakeLists.txt
An outcome of updating the cmake files is that it fixes the library path obtained by cmdgui.rb such that it points to the .so file contained in the non-dev debian package.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.