Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JUST FOR TESTING Remove redundant auto header and its redirection header #491

Closed
wants to merge 2 commits into from

Conversation

methylDragon
Copy link
Contributor

@methylDragon methylDragon commented Sep 14, 2022

From gazebosim/gz-physics#305 we know that gz_auto_header.hh.in files are not being used. The problem is that they're not being used AND there is a redirection header that points to nowhere because of it.

This causes the ABI checker to fail (surfaced by #486). So this PR fixes that issue by removing both files.

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Sep 14, 2022
@methylDragon
Copy link
Contributor Author

Closing because it's a duplicate of #490 (oops)

@methylDragon methylDragon deleted the ch3/hotfix-abi-checker branch September 14, 2022 04:33
@methylDragon methylDragon changed the title Remove redundant auto header and its redirection header JUST FOR TESTING Remove redundant auto header and its redirection header Sep 14, 2022
@methylDragon methylDragon restored the ch3/hotfix-abi-checker branch September 14, 2022 04:35
@methylDragon methylDragon reopened this Sep 14, 2022
@methylDragon methylDragon marked this pull request as draft September 14, 2022 04:35
@methylDragon methylDragon deleted the ch3/hotfix-abi-checker branch September 14, 2022 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant