Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the warnings present in main jobs of he buildfarm.
Reference build:
https://build.osrfoundation.org/job/gz_gui-ci-main-noble-amd64/5/
There are two warnings being fixed:
In MinimalScene plugin, if
GZ_GUI_HAVE_VULKAN
is not defined, the parameter_camera
of theTextureNode
constructor is not used. I added a void statement to suppress that warning.In ImageDisplay plugin tests, there are shared_pointers declared with an incompatible new/delete match.
std::shared_ptr<unsigned char> buffer(new unsigned char[bufferSize]);
Given that the shared pointer is not declared as an array, the tests leak memory as they are right now. I added a fix for all of those tests.
cc: @Crola1702
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.