Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler warnings #623

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Conversation

Blast545
Copy link
Contributor

@Blast545 Blast545 commented Jun 3, 2024

Summary

Fixes the warnings present in main jobs of he buildfarm.

Reference build:
https://build.osrfoundation.org/job/gz_gui-ci-main-noble-amd64/5/

There are two warnings being fixed:

  1. In MinimalScene plugin, if GZ_GUI_HAVE_VULKAN is not defined, the parameter _camera of the TextureNode constructor is not used. I added a void statement to suppress that warning.

  2. In ImageDisplay plugin tests, there are shared_pointers declared with an incompatible new/delete match.
    std::shared_ptr<unsigned char> buffer(new unsigned char[bufferSize]);
    Given that the shared pointer is not declared as an array, the tests leak memory as they are right now. I added a fix for all of those tests.

cc: @Crola1702

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Jorge J. Perez <[email protected]>
@Blast545 Blast545 requested a review from jennuine as a code owner June 3, 2024 15:20
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Jun 3, 2024
@Blast545 Blast545 self-assigned this Jun 3, 2024
@Blast545
Copy link
Contributor Author

Blast545 commented Jun 3, 2024

AFAIK, gz_gui-ci-pr_any-jammy-amd64 shouldn't be running on gui-main. Given that gz_gui-ci-pr_any-noble-amd64 is green, I will go ahead and merge this PR.

Edit: I can't merge because the check is set as "required" t-t

@Blast545 Blast545 enabled auto-merge (squash) June 3, 2024 16:56
@Blast545 Blast545 merged commit 13775fa into main Jun 3, 2024
8 checks passed
@Blast545 Blast545 deleted the blast545/fix_warnings_main_2024_jun3 branch June 3, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants