Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumps in garden: depend on ign-common5, ign-math7, ign-physcs6, sdf13 #145

Merged
merged 1 commit into from
Dec 30, 2021
Merged

Bumps in garden: depend on ign-common5, ign-math7, ign-physcs6, sdf13 #145

merged 1 commit into from
Dec 30, 2021

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina requested a review from nkoenig as a code owner December 27, 2021 18:05
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Dec 27, 2021
@chapulina chapulina added the needs upstream release Blocked by a release of an upstream library label Dec 27, 2021
@chapulina chapulina requested a review from scpeters December 27, 2021 22:44
@chapulina chapulina removed the needs upstream release Blocked by a release of an upstream library label Dec 30, 2021
@codecov
Copy link

codecov bot commented Dec 30, 2021 •
edited
Loading

Codecov Report

Merging #145 (f212ade) into main (0d3909e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #145   +/-   ##
=======================================
  Coverage   32.92%   32.92%           
=======================================
  Files           4        4           
  Lines         817      817           
=======================================
  Hits          269      269           
  Misses        548      548

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d3909e...f212ade. Read the comment docs.

@chapulina chapulina changed the title Bumps in garden : ci_matching_branch/bump_garden_ign-launch6 Bumps in garden: depend on ign-common5, ign-math7, ign-physcs6, sdf13 Dec 30, 2021
@chapulina
Copy link
Contributor Author

CI is happy, this and its infrastructure PRs are ready to go in:

@chapulina
Copy link
Contributor Author

Merging without an approval so we can complete the Garden bumps this year. This PR is very low risk compared to the rest of the bumps.

@chapulina
Copy link
Contributor Author

Saved by the 🔔 , thanks @ahcorde

@chapulina chapulina merged commit 3318398 into main Dec 30, 2021
@chapulina chapulina deleted the ci_matching_branch/bump_garden_ign-launch6 branch December 30, 2021 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@nkoenig nkoenig Awaiting requested review from nkoenig nkoenig is a code owner

@scpeters scpeters Awaiting requested review from scpeters

Assignees
No one assigned
Labels
🌱 garden Ignition Garden
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chapulina @ahcorde