Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz CLI Migration : gz-launch #169

Merged
merged 2 commits into from
Jun 22, 2022
Merged

ign -> gz CLI Migration : gz-launch #169

merged 2 commits into from
Jun 22, 2022

Conversation

methylDragon
Copy link
Contributor

@methylDragon methylDragon mentioned this pull request Jun 12, 2022
Closed
18 tasks
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 12, 2022
@methylDragon methylDragon marked this pull request as ready for review June 13, 2022 05:37
@methylDragon methylDragon requested a review from nkoenig as a code owner June 13, 2022 05:37
@methylDragon methylDragon force-pushed the cli_migration branch 3 times, most recently from dc1aef7 to 7fcb2a6 Compare June 13, 2022 06:22
@methylDragon methylDragon added the needs upstream release Blocked by a release of an upstream library label Jun 13, 2022
@methylDragon
Copy link
Contributor Author

CI failure needs the merge of gz-tools so the gz executable is available

@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label Jun 13, 2022
@methylDragon
Move CLI files
a795c2a 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Migrate CLI
1707ef7 
Signed-off-by: methylDragon <[email protected]>
@codecov
Copy link

codecov bot commented Jun 21, 2022 •
edited
Loading

Codecov Report

Merging #169 (1707ef7) into main (29f2a47) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #169   +/-   ##
=======================================
  Coverage   32.40%   32.40%           
=======================================
  Files           4        4           
  Lines         830      830           
=======================================
  Hits          269      269           
  Misses        561      561
Impacted Files Coverage Δ
src/cmd/gz.cc 80.00% <ø> (ø)
src/cmd/launch_main.cc 69.11% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29f2a47...1707ef7. Read the comment docs.

chapulina
chapulina approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UNIT_gz_TEST passing on Linux and macOS 🚀

@chapulina chapulina merged commit 184b285 into main Jun 22, 2022
@chapulina chapulina deleted the cli_migration branch June 22, 2022 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@nkoenig nkoenig Awaiting requested review from nkoenig nkoenig is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo. needs upstream release Blocked by a release of an upstream library
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@methylDragon @chapulina