Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ign -> gz Provisional Finale: Source Migration : gz-launch #177

Closed
wants to merge 3 commits into from

Conversation

methylDragon
Copy link
Contributor

@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #177 (cf8e781) into main (e05d212) will not change coverage.
The diff coverage is 100.00%.

❗ Current head cf8e781 differs from pull request most recent head 68649a8. Consider uploading reports for the commit 68649a8 to get more accurate results

@@           Coverage Diff           @@
##             main     #177   +/-   ##
=======================================
  Coverage   32.49%   32.49%           
=======================================
  Files           4        4           
  Lines         834      834           
=======================================
  Hits          271      271           
  Misses        563      563           
Impacted Files Coverage Δ
src/cmd/launch_main.cc 69.11% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e05d212...68649a8. Read the comment docs.

@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label Jul 14, 2022
CMakeLists.txt Outdated
gz_configure_project(
REPLACE_IGNITION_INCLUDE_PATH gz/launch
VERSION_SUFFIX)
gz_configure_project(VERSION_SUFFIX)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, this should have pre1, it's been wrong all along

Copy link
Contributor Author

@methylDragon methylDragon Jul 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I'll fix this in #176

This is the only change that's made here, which is kind of a waste of a commit... I'll close this PR

Signed-off-by: methylDragon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants