Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IGNITION_MATH_XXX_VERSION #151

Merged
merged 2 commits into from
Aug 27, 2020
Merged

Fix IGNITION_MATH_XXX_VERSION #151

merged 2 commits into from
Aug 27, 2020

Conversation

caguero
Copy link
Contributor

@caguero caguero commented Aug 27, 2020

This was the generated content before this patch:

/* Config.hh. Generated by CMake for ignition-math. */

/* Version number */
#define IGNITION_MATH_MAJOR_VERSION 
#define IGNITION_MATH_MINOR_VERSION 
#define IGNITION_MATH_PATCH_VERSION 

#define IGNITION_MATH_VERSION "6.4"
#define IGNITION_MATH_VERSION_FULL "6.4.0"

#define IGNITION_MATH_VERSION_NAMESPACE v6

#define IGNITION_MATH_VERSION_HEADER "Ignition math, version 6.4.0\nCopyright (C) 2014 Open Source Robotics Foundation.\nReleased under the Apache 2.0 License.\n\n"

/* #undef IGNITION_MATH_BUILD_TYPE_PROFILE */
/* #undef IGNITION_MATH_BUILD_TYPE_DEBUG */
/* #undef IGNITION_MATH_BUILD_TYPE_RELEASE */

And now with the fix:

/* Config.hh. Generated by CMake for ignition-math. */

/* Version number */
#define IGNITION_MATH_MAJOR_VERSION 6
#define IGNITION_MATH_MINOR_VERSION 4
#define IGNITION_MATH_PATCH_VERSION 0

#define IGNITION_MATH_VERSION "6.4"
#define IGNITION_MATH_VERSION_FULL "6.4.0"

#define IGNITION_MATH_VERSION_NAMESPACE v6

#define IGNITION_MATH_VERSION_HEADER "Ignition math, version 6.4.0\nCopyright (C) 2014 Open Source Robotics Foundation.\nReleased under the Apache 2.0 License.\n\n"

/* #undef IGNITION_MATH_BUILD_TYPE_PROFILE */
/* #undef IGNITION_MATH_BUILD_TYPE_DEBUG */
/* #undef IGNITION_MATH_BUILD_TYPE_RELEASE */

Signed-off-by: Carlos Agüero <[email protected]>
@caguero caguero requested a review from scpeters as a code owner August 27, 2020 08:46
@github-actions github-actions bot added 🏰 citadel Ignition Citadel 📜 blueprint Ignition Blueprint 🔮 dome Ignition Dome labels Aug 27, 2020
@codecov
Copy link

codecov bot commented Aug 27, 2020

Codecov Report

Merging #151 into ign-math6 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           ign-math6     #151   +/-   ##
==========================================
  Coverage      99.25%   99.25%           
==========================================
  Files             59       59           
  Lines           5788     5788           
==========================================
  Hits            5745     5745           
  Misses            43       43           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7fffec...2edacff. Read the comment docs.

@scpeters
Copy link
Member

@osrf-jenkins run tests please

@chapulina chapulina merged commit 9ff0f1c into ign-math6 Aug 27, 2020
@chapulina chapulina deleted the fix_versions branch August 27, 2020 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 blueprint Ignition Blueprint 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants