Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for printing inf Vector3 #168

Merged
merged 1 commit into from
Oct 19, 2020

Conversation

nlamprian
Copy link
Contributor

The reported exception is not the case anymore with std::round, which returns inf as expected.

Closes #64

Signed-off-by: Nick Lamprianidis [email protected]

@nlamprian nlamprian requested a review from scpeters as a code owner October 18, 2020 01:47
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🏰 citadel Ignition Citadel 📜 blueprint Ignition Blueprint 🔮 dome Ignition Dome labels Oct 18, 2020
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you for checking that this isn't a problem anymore and for the added test.

I just have the 2 trivial comments below, otherwise this looks good to me 👍

src/Vector3_TEST.cc Outdated Show resolved Hide resolved
src/Vector3_TEST.cc Outdated Show resolved Hide resolved
Closes gazebosim#64

Signed-off-by: Nick Lamprianidis <[email protected]>
@nlamprian nlamprian force-pushed the nlamprian/print_inf_vec branch from 90c1c84 to e1f41c6 Compare October 18, 2020 18:57
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@chapulina chapulina merged commit 3e576bc into gazebosim:ign-math6 Oct 19, 2020
@nlamprian nlamprian deleted the nlamprian/print_inf_vec branch October 26, 2020 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 blueprint Ignition Blueprint 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants