-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bazel Updates for math6 #171
Conversation
Co-authored-by: John Shepherd <[email protected]> Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-math6 #171 +/- ##
==========================================
Coverage 99.20% 99.20%
==========================================
Files 63 63
Lines 6019 6019
==========================================
Hits 5971 5971
Misses 48 48 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builds and runs fine with all tests passing for bazel
and colcon
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
are we going to setup CI for bazel to prevent regressions? |
Just added the |
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know much about Bazel, but I didn't notice anything weird, and CI that's using this branch seems to be happy with ign-math
:
https://github.com/ignitionrobotics/ign-bazel/runs/2068842483?check_suite_focus=true
The branch for that build is configured here:
Rebase the bazel branch to be off of math6, the version used in dome.
Specific cleanups and feedback incorporated in 18b35a0
This will replace the current
bazel
branch.