Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel Updates for math6 #171

Merged
merged 17 commits into from
Mar 16, 2021
Merged

Bazel Updates for math6 #171

merged 17 commits into from
Mar 16, 2021

Conversation

mjcarroll
Copy link
Contributor

Rebase the bazel branch to be off of math6, the version used in dome.

Specific cleanups and feedback incorporated in 18b35a0

This will replace the current bazel branch.

mjcarroll and others added 6 commits October 20, 2020 14:45
Co-authored-by: John Shepherd <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🏰 citadel Ignition Citadel 📜 blueprint Ignition Blueprint 🔮 dome Ignition Dome labels Oct 23, 2020
@codecov
Copy link

codecov bot commented Oct 23, 2020

Codecov Report

Merging #171 (90cbf4b) into ign-math6 (1e9ce65) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           ign-math6     #171   +/-   ##
==========================================
  Coverage      99.20%   99.20%           
==========================================
  Files             63       63           
  Lines           6019     6019           
==========================================
  Hits            5971     5971           
  Misses            48       48           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e9ce65...5794ee7. Read the comment docs.

eigen3/BUILD.bazel Outdated Show resolved Hide resolved
eigen3/BUILD.bazel Outdated Show resolved Hide resolved
@JShep1 JShep1 self-requested a review November 25, 2020 01:16
Copy link

@JShep1 JShep1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs fine with all tests passing for bazel and colcon

@mjcarroll mjcarroll marked this pull request as ready for review December 1, 2020 21:37
@mjcarroll mjcarroll requested a review from scpeters as a code owner December 1, 2020 21:37
Signed-off-by: John Shepherd <[email protected]>
@scpeters
Copy link
Member

scpeters commented Dec 2, 2020

are we going to setup CI for bazel to prevent regressions?

@JShep1
Copy link

JShep1 commented Dec 2, 2020

Just added the Capsule class. This brings up a good point, perhaps we eventually want to glob for files? We're globbing for tests so it will automatically break CI if someone adds new files and tests for them since the bazel build files will pick up the new tests but not the new files.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about Bazel, but I didn't notice anything weird, and CI that's using this branch seems to be happy with ign-math:

https://github.com/ignitionrobotics/ign-bazel/runs/2068842483?check_suite_focus=true

The branch for that build is configured here:

https://github.com/ignitionrobotics/ign-bazel/blob/6c7128cb4833bbbb06d397f785c61d02d7f8b962/.github/ci/bazel.repos#L5

@mjcarroll mjcarroll merged commit b84710d into ign-math6 Mar 16, 2021
@mjcarroll mjcarroll deleted the bazel-math6 branch March 16, 2021 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 blueprint Ignition Blueprint 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants