👩‍🌾 Don't use std::pow with integers in Vectors

[chapulina]

🦟 Bug fix

Summary

ign-gazebo has the following Windows warning tracing back to ign-math:

[283.328s] C:\Jenkins\workspace\ign_gazebo-pr-win\ws\install\ignition-math6\include\ignition\math6\ignition/math/Vector2.hh(98,14): warning C4244: 'return': conversion from 'double' to 'T', possible loss of data [C:\Jenkins\workspace\ign_gazebo-pr-win\ws\build\ignition-gazebo5\src\gui\plugins\scene3d\GzScene3D.vcxproj]

We don't have lots of tests using integers as templates, so we didn't catch that here. It would be interesting to add tests for that.

I noticed other uses of std::pow in the codebase in classes like Inertial, MassMatrix3, Sphere, etc. Some of them don't have integer typedefs (i.e. there's no Inertiali), but some of them do (Spherei). I'm not sure we have valid use cases for integer shapes, so I didn't add tests for them or updated the std::pow usage for now.

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

https://github.com/osrf/buildfarmer/issues/181

[scpeters]

the Length functions have errors on Windows now

[chapulina]

the Length functions have errors on Windows now

Yes! I love it when tests do their job! Looking into it.