Remove tools in favor of make codecheck

[chapulina]

Summary

Removing:

• tools/code_check.sh and family, which used to be used on Jenkins but hasn't been working, see Jenkins is not reporting cppcheck failures gazebo-tooling/release-tools#446

In favor of:

• make codecheck, which is used on Actions and can't be used (nicely) on Jenkins yet because of Use make codecheck on ubuntu gazebo-tooling/release-tools#148

Test it

Check out CI results

Checklist

• Signed all commits for DCO
• Added tests
• Added example and/or tutorial
• Updated documentation (as needed)
• Updated migration guide (as needed)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

[scpeters]

we still need tools/check_test_ran.py

[chapulina]

we still need tools/check_test_ran.py

Restored in 1c4e12d. Do you think this is something reasonable to move to ign-cmake?

[chapulina]

something reasonable to move to ign-cmake?

Probably yes, it's used by it: https://github.com/ignitionrobotics/ign-cmake/blob/17b7058ff5c9de2f6f396d1a000dd0366481d621/cmake/IgnUtils.cmake#L1721

[scpeters]

something reasonable to move to ign-cmake?

Probably yes, it's used by it: https://github.com/ignitionrobotics/ign-cmake/blob/17b7058ff5c9de2f6f396d1a000dd0366481d621/cmake/IgnUtils.cmake#L1721

since we aren't using QTest anymore (gazebosim/gz-gui#198 (comment)), I think it can be moved to ign-cmake. There are a few variants of check_test_ran.py in our packages, so we should make sure to get the one that uses an informative classname:

• not helpful: https://github.com/ignitionrobotics/ign-cmake/blob/ign-cmake2/tools/check_test_ran.py#L73
• helpful: https://github.com/ignitionrobotics/ign-gazebo/blob/ign-gazebo5/tools/check_test_ran.py#L73

[chapulina]

It looks like we don't even need gazebo-tooling/release-tools#455, the job already ignores a missing code_check file:

sh: 0: Can't open tools/code_check.sh
+ true

[chapulina]

I think it can be moved to ign-cmake

• Removed check_test_ran from this repo in e12d976.
• Updating ign-cmake in Run ign-cmake's copy of check_test_ran gz-cmake#168
• Test run: (uses https://github.com/ignition-tooling/release-tools/compare/chapulina/math/211)

[codecov]

Codecov Report

Merging #211 (6bf2f4d) into ign-math6 (f6e367f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           ign-math6     #211   +/-   ##
==========================================
  Coverage      99.21%   99.21%           
==========================================
  Files             65       65           
  Lines           6089     6089           
==========================================
  Hits            6041     6041           
  Misses            48       48           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6e367f...6bf2f4d. Read the comment docs.