-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OrientedBox Python interface #276
Conversation
Signed-off-by: ahcorde <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-math6 #276 +/- ##
==========================================
Coverage 99.41% 99.41%
==========================================
Files 67 67
Lines 6374 6374
==========================================
Hits 6337 6337
Misses 37 37 Continue to review full report at Codecov.
|
src/python/OrientedBox_TEST.py
Outdated
box = OrientedBoxd(Vector3d(0.1, -2.1, 0.0)) | ||
self.assertEqual(box.xlength(), 0.1) | ||
self.assertEqual(box.ylength(), 2.1) | ||
self.assertEqual(box.zlength(), 0.0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know we've already merged support for AxisAlignedBox
with XLength()
in c++ mapped to xlength()
in python (and simlar for y, z), but I think it would look nicer as x_length
, y_length
and z_length
. Is there an easy way to do that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, I see that we've done that for Quaternion and PID already with %rename()
, so I'll add that here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
similar change for AxisAlignedBox
in #281
Signed-off-by: Steve Peters <[email protected]>
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1 |
Signed-off-by: ahcorde [email protected]
🎉 New feature
Summary
Added OrientedBox Python interface.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge