Added PID pybind11 interface #323
Conversation
Signed-off-by: ahcorde <[email protected]>
github-actions
bot
added
Gazebo 1️1️
Signed-off-by: ahcorde <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-math6 #323 +/- ##
==========================================
Coverage 99.65% 99.65%
==========================================
Files 67 67
Lines 6359 6380 +21
==========================================
+ Hits 6337 6358 +21
Misses 22 22
Continue to review full report at Codecov.
|
| self.update_test(pid, 0, -1, -1, -1, 0, 0) | ||
| self.update_test(pid, 0, 1, -1, 1, 0, -2) |
There was a problem hiding this comment.
Why are these 2 test cases being removed?
There was a problem hiding this comment.
I didn't dig a lot on this, but could be related with the python module datetime timedelta
There was a problem hiding this comment.
I added some TODOs in 980b23b, we should look into this after the pybind11 migration is over. It's strange that the results are different from SWIG and C++
Signed-off-by: Louise Poubel <[email protected]>
| self.update_test(pid, 0, -1, -1, -1, 0, 0) | ||
| self.update_test(pid, 0, 1, -1, 1, 0, -2) |
There was a problem hiding this comment.
I added some TODOs in 980b23b, we should look into this after the pybind11 migration is over. It's strange that the results are different from SWIG and C++
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1 |
Signed-off-by: ahcorde [email protected]
🎉 New feature
Summary
This PR creates a PID Pybind11 interface
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.