Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 6 -> 7 as of pybind11 GaussMarkovProcess #379

Merged
merged 17 commits into from
Feb 25, 2022

Conversation

scpeters
Copy link
Member

➡️ Forward port

Port ign-math6 to main as of #315.

Branch comparison: main...7717f49

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

ahcorde and others added 15 commits December 23, 2021 22:56
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>

Co-authored-by: Louise Poubel <[email protected]>
Signed-off-by: Alejandro Hernández <[email protected]>

Co-authored-by: Louise Poubel <[email protected]>
Signed-off-by: Alejandro Hernández <[email protected]>

Co-authored-by: Louise Poubel <[email protected]>
Signed-off-by: Alejandro Hernández <[email protected]>

Co-authored-by: Louise Poubel <[email protected]>
Signed-off-by: Alejandro Hernández <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>

Co-authored-by: Louise Poubel <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>

Co-authored-by: Louise Poubel <[email protected]>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Feb 25, 2022
scpeters added a commit to scpeters/ign-math that referenced this pull request Feb 25, 2022
This replaces deprecated method names with the new names.

Signed-off-by: Steve Peters <[email protected]>
This replaces deprecated method names with the new names.

Signed-off-by: Steve Peters <[email protected]>
@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #379 (d0ed5be) into main (04028c9) will not change coverage.
The diff coverage is n/a.

❗ Current head d0ed5be differs from pull request most recent head 56b896c. Consider uploading reports for the commit 56b896c to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #379   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files          65       65           
  Lines        6111     6111           
=======================================
  Hits         6089     6089           
  Misses         22       22           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04028c9...56b896c. Read the comment docs.

Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have a warning related with Quaternion<int> I don't know if does make sense or not to have a class like this. Few can only represents with this class a few angles.

@scpeters
Copy link
Member Author

we have a warning related with Quaternion<int> I don't know if does make sense or not to have a class like this. Few can only represents with this class a few angles.

I agree it doesn't make much sense, but it might be needed for Matrix3i due to the coupling between Matrix3 and Quaternion

I've cherry-picked the fix for the warning from part of #361

@scpeters scpeters requested a review from ahcorde February 25, 2022 18:49
@scpeters scpeters merged commit 27de5e0 into gazebosim:main Feb 25, 2022
@scpeters scpeters deleted the merge_6_7 branch February 25, 2022 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants