Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add polynomial3 python binding #439

Closed
wants to merge 8 commits into from
Closed

Conversation

adityapande-1995
Copy link
Contributor

@adityapande-1995 adityapande-1995 commented Jun 8, 2022

Signed-off-by: Aditya [email protected]

🎉 New feature

Closes #394

Summary

Adds pybind11 python bindings for Polynomial class

Test it

Added test cases to Polynomial3_TESTS.py

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 8, 2022
@adityapande-1995 adityapande-1995 marked this pull request as draft June 8, 2022 00:36
@chapulina chapulina added the scripting Scripting interfaces to Ignition label Jun 8, 2022
@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #439 (4f84b4d) into main (34d481d) will not change coverage.
The diff coverage is n/a.

❗ Current head 4f84b4d differs from pull request most recent head fbdf69f. Consider uploading reports for the commit fbdf69f to get more accurate results

@@           Coverage Diff           @@
##             main     #439   +/-   ##
=======================================
  Coverage   99.68%   99.68%           
=======================================
  Files          73       73           
  Lines        6631     6631           
=======================================
  Hits         6610     6610           
  Misses         21       21           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34d481d...fbdf69f. Read the comment docs.

@adityapande-1995 adityapande-1995 marked this pull request as ready for review June 21, 2022 22:39
@adityapande-1995
Copy link
Contributor Author

Same as #451

@adityapande-1995 adityapande-1995 deleted the aditya/poly3_python branch August 9, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden scripting Scripting interfaces to Ignition
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants