Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pytest to generate junit xml files for python tests #446

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jun 29, 2022

Signed-off-by: ahcorde [email protected]

🦟 Bug fix

Summary

Python unit tests currently don't generate junit xml files for consumption by Jenkins. This results in Jenkins indicating that there are no failing tests when python tests are failing. couldn't find a way to generate these files using the builtin unittest python library, so I have added a dependency on pytest. If pytest is not available, a CMake warning is emitted.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ahcorde ahcorde self-assigned this Jun 29, 2022
@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #446 (a30f5bc) into ign-math6 (73b23d1) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           ign-math6     #446   +/-   ##
==========================================
  Coverage      99.65%   99.65%           
==========================================
  Files             67       67           
  Lines           6392     6392           
==========================================
  Hits            6370     6370           
  Misses            22       22           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73b23d1...a30f5bc. Read the comment docs.

@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels Jun 29, 2022
@ahcorde ahcorde merged commit b6f9587 into ign-math6 Jun 29, 2022
@ahcorde ahcorde deleted the ahcorde/6/use_pytest branch June 29, 2022 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🏯 fortress Ignition Fortress Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants