Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration guide: remove outdated entry #499

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Fixes migration guide as follow up to #454

Summary

A variant of appendToStream was deprecated in #376, but then it was removed in #454 after recalling that it hadn't yet been released. This updates the Migration guide to remove the deprecation entry for the removed method.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@scpeters scpeters requested a review from jennuine September 12, 2022 17:51
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Sep 12, 2022
@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #499 (a2a5643) into gz-math7 (b9d69e5) will not change coverage.
The diff coverage is n/a.

❗ Current head a2a5643 differs from pull request most recent head 1865a82. Consider uploading reports for the commit 1865a82 to get more accurate results

@@            Coverage Diff            @@
##           gz-math7     #499   +/-   ##
=========================================
  Coverage     99.70%   99.70%           
=========================================
  Files            77       77           
  Lines          7007     7007           
=========================================
  Hits           6986     6986           
  Misses           21       21           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@scpeters scpeters merged commit 31bd899 into gz-math7 Sep 13, 2022
@scpeters scpeters deleted the scpeters/fix_migration branch September 13, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants