Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lightmap texcoord set field #124

Merged
merged 1 commit into from
Jan 12, 2021
Merged

Add lightmap texcoord set field #124

merged 1 commit into from
Jan 12, 2021

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jan 9, 2021

needed by gazebosim/gz-sim#471

the light_map field was recently added but we also need to specify the texture coordinate set for the lightmap.

Signed-off-by: Ian Chen [email protected]

@iche033 iche033 requested a review from caguero as a code owner January 9, 2021 06:31
@codecov
Copy link

codecov bot commented Jan 9, 2021

Codecov Report

Merging #124 (2686fc5) into main (668a75b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #124   +/-   ##
=======================================
  Coverage   84.59%   84.59%           
=======================================
  Files           7        7           
  Lines         818      818           
=======================================
  Hits          692      692           
  Misses        126      126           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 668a75b...2686fc5. Read the comment docs.

@chapulina
Copy link
Contributor

Merging now so it gets into the nightly build.

@chapulina chapulina merged commit b581eb1 into main Jan 12, 2021
@chapulina chapulina deleted the lightmap_texcoord_set branch January 12, 2021 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants