Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 'has' functionality in particle Emitter. #137

Merged
merged 3 commits into from
Feb 26, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions Migration.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,14 @@ Deprecated code produces compile-time warnings. These warning serve as
notification to users that their code should be upgraded. The next major
release will remove the deprecated code.

## Ignition Msgs 6.3 to 6.4

### Modifications

1. **particle_emitter.proto**
+ Fields have changed from plain data types to messages.
* See [PR 137](https://github.com/ignitionrobotics/ign-msgs/pull/137)

## Ignition Msgs 4.X to 5.X

### Modifications
Expand Down
19 changes: 11 additions & 8 deletions proto/ignition/msgs/particle_emitter.proto
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,13 @@ option java_outer_classname = "ParticleEmitterProtos";
/// \interface ParticleEmitter
/// \brief Message for a particle emitter.

import "ignition/msgs/boolean.proto";
import "ignition/msgs/color.proto";
import "ignition/msgs/float.proto";
import "ignition/msgs/header.proto";
import "ignition/msgs/material.proto";
import "ignition/msgs/pose.proto";
import "ignition/msgs/stringmsg.proto";
import "ignition/msgs/vector3d.proto";

message ParticleEmitter
Expand Down Expand Up @@ -63,29 +66,29 @@ message ParticleEmitter
Vector3d size = 6;

/// \brief How many particles per second should be emitted.
float rate = 7;
Float rate = 7;

/// \brief The number of seconds the emitter is active.
float duration = 8;
Float duration = 8;

/// \brief Whether particle emitter is enabled or not.
bool emitting = 9;
Boolean emitting = 9;

/// \brief The particle dimensions (width, height, depth).
Vector3d particle_size = 10;

/// \brief The number of seconds each particle will ’live’ for before
/// being destroyed.
float lifetime = 11;
Float lifetime = 11;

/// \brief The material which all particles in the emitter will use.
Material material = 12;

/// \brief The minimum velocity each particle is emitted (m/s).
float min_velocity = 13;
Float min_velocity = 13;

/// \brief The maximum velocity each particle is emitted (m/s).
float max_velocity = 14;
Float max_velocity = 14;

/// \brief The starting color of the particles.
Color color_start = 15;
Expand All @@ -95,8 +98,8 @@ message ParticleEmitter

/// \brief The amount by which to scale the particles in both x and y
/// direction per second (screen coordinates).
float scale_rate = 17;
Float scale_rate = 17;

/// \brief The path to the color image used as an affector.
string color_range_image = 18;
StringMsg color_range_image = 18;
}