Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel build support for ign-msgs7 #168

Closed
wants to merge 4 commits into from
Closed

Bazel build support for ign-msgs7 #168

wants to merge 4 commits into from

Conversation

mjcarroll
Copy link
Contributor

@mjcarroll mjcarroll commented Jul 13, 2021

🎉 New feature

Summary

Adds build infrastructure for Bazel in ign-msgs7

Test it

Follow instructions on setting up the bazel build environment from https://github.com/ignitionrobotics/ign-bazel

Then:

bazel build //ign_msgs

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@mjcarroll mjcarroll requested a review from caguero as a code owner July 13, 2021 18:12
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Jul 13, 2021
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tried building with Bazel but I took a high-level look and nothing seemed strange

BUILD.bazel Outdated

PROJECT_MAJOR = 7

PROJECT_MINOR = 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Louise Poubel <[email protected]>
@chapulina
Copy link
Contributor

#95 was forward-ported on #170, so I believe this PR isn't needed anymore

@chapulina chapulina closed this Jul 20, 2021
@chapulina chapulina deleted the bazel-msgs7 branch July 20, 2021 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants