-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds PerformanceSensorMetrics proto message. #172
Conversation
Signed-off-by: Franco Cipollone <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-msgs5 #172 +/- ##
==========================================
Coverage 84.38% 84.38%
==========================================
Files 7 7
Lines 807 807
==========================================
Hits 681 681
Misses 126 126 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we suppose to fill all the fields when publishing this message? If the answer is no, consider to use StringMsg
and Double
instead, as we can check if the field has been set when parsing the message.
Thanks for the suggestion. All but I will address it, thanks! |
Signed-off-by: Franco Cipollone <[email protected]>
d2dbc19
to
6237f9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
What is the difference between |
Also, another interesting metric might be how long did the |
🎉 New feature
Related to gazebosim/gz-sim#557
Related to gazebosim/gz-sensors#146
Summary
Adds a message to publish performance metrics of the sensors.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge