Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge ign-msgs5 ➡️ ign-msgs8 #264

Merged
merged 2 commits into from
Jun 23, 2022
Merged

Merge ign-msgs5 ➡️ ign-msgs8 #264

merged 2 commits into from
Jun 23, 2022

Conversation

chapulina
Copy link
Contributor

➡️ Forward port

Port ign-msgs5 ➡️ ign-msgs8

Branch comparision: ign-msgs8...ign-msgs5

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

mabelzhang and others added 2 commits June 15, 2022 01:42
@mabelzhang @chapulina
Bash completion for flags (#254)
97ea6f5 
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>

Co-authored-by: Louise Poubel <[email protected]>
@chapulina
5 -> 8
461e598 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina requested a review from caguero as a code owner June 23, 2022 03:22
@chapulina chapulina mentioned this pull request Jun 23, 2022
Merged
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jun 23, 2022
@codecov
Copy link

codecov bot commented Jun 23, 2022 •
edited
Loading

Codecov Report

Merging #264 (70df8f4) into ign-msgs8 (d426ba7) will not change coverage.
The diff coverage is n/a.

❗ Current head 70df8f4 differs from pull request most recent head 461e598. Consider uploading reports for the commit 461e598 to get more accurate results

@@            Coverage Diff             @@
##           ign-msgs8     #264   +/-   ##
==========================================
  Coverage      85.38%   85.38%           
==========================================
  Files              9        9           
  Lines            951      951           
==========================================
  Hits             812      812           
  Misses           139      139

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d426ba7...461e598. Read the comment docs.

@chapulina chapulina merged commit 1ab6c70 into ign-msgs8 Jun 23, 2022
@chapulina chapulina deleted the chapulina/5_to_8 branch June 23, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@caguero caguero Awaiting requested review from caguero caguero is a code owner

Assignees
No one assigned
Labels
🏯 fortress Ignition Fortress
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chapulina @ahcorde @mabelzhang