-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase Utility coverage #283
Conversation
Signed-off-by: Jenn Nguyen <[email protected]>
Signed-off-by: Jenn Nguyen <[email protected]>
Signed-off-by: Jenn Nguyen <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-msgs5 #283 +/- ##
==============================================
+ Coverage 85.27% 97.12% +11.85%
==============================================
Files 9 9
Lines 903 905 +2
==============================================
+ Hits 770 879 +109
+ Misses 133 26 -107
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see the coverage efforts resulting in implementation improvements 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'll leave it up to you if you think the nitpick is worth addressing.
Signed-off-by: Jenn Nguyen <[email protected]>
Part of gazebosim/gz-sim#1575
Summary
Utility.cc
coverage by adding tests forConvertFuelMetadata
methodsConvertFuelMetadata(string, msgs::FuelMetadata)
function to take care of<world>
: a1d294d (commit message is backwards 😅)split
function: 8ff8356Test it
./path/to/build/UNIT_Utility_TEST --gtest_filter="*ConvertFuelMetadata"
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.