Support multiple messages in a proto file #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
==========================================
+ Coverage 85.66% 85.69% +0.03%
==========================================
Files 7 7
Lines 795 797 +2
==========================================
+ Hits 681 683 +2
Misses 114 114
Continue to review full report at Codecov.
|
Signed-off-by: Carlos Aguero <[email protected]>
|
I took the liberty of adding a few extra checks to make sure that all smart pointer flavors compile. b961a91. Waiting for CI but all looks good to me! |
caguero
approved these changes
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #69
We have a few proto files that define more than one message. These messages have been working with Ignition Transport, but they didn't work with the factory. This PR updates the generator so that all messages in a file are registered with the factory. It also adds the special pointer types for them.
I'm targeting this at
master(future Dome branch), because I believe that the change in the name of the static object created in the macro will break ABI. This is unfortunate, but I'm not sure how to work around that.