Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions for default valued materials #63

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

azeey
Copy link
Collaborator

@azeey azeey commented Jun 3, 2022

Summary

The default value of a materials rgba is [1 1 1 1], so I thought we should use that when material.rgba is None. This also increases test coverage by testing default values of emission and specular. The documentation on material.rgba also states

Note that textures are applied in GL_MODULATE mode, meaning that the texture color and the color specified here are multiplied component-wise.
So, we should not discard the rgba values when setting textures.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey requested a review from ahcorde June 3, 2022 16:45
@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #63 (8441891) into ahcorde/mjcf2sdf/material (5c9eb8a) will increase coverage by 0.22%.
The diff coverage is 100.00%.

@@                      Coverage Diff                      @@
##           ahcorde/mjcf2sdf/material      #63      +/-   ##
=============================================================
+ Coverage                      96.98%   97.20%   +0.22%     
=============================================================
  Files                             19       19              
  Lines                            828      824       -4     
=============================================================
- Hits                             803      801       -2     
+ Misses                            25       23       -2     
Impacted Files Coverage Δ
...o_sdformat/mjcf_to_sdformat/converters/material.py 91.48% <100.00%> (+3.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c9eb8a...8441891. Read the comment docs.

@azeey azeey merged commit e19d5a2 into ahcorde/mjcf2sdf/material Jun 3, 2022
@azeey azeey deleted the azeey/material_suggestions branch June 3, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants