Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new Joint APIs for Parent/Child name #92

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Follow-up to gazebosim/sdformat#1053.

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #92 (f0d48c2) into main (59a00a7) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #92   +/-   ##
=======================================
  Coverage   95.17%   95.17%           
=======================================
  Files          24       24           
  Lines        1099     1099           
=======================================
  Hits         1046     1046           
  Misses         53       53           
Impacted Files Coverage Δ
...sdformat_mjcf/mjcf_to_sdformat/converters/joint.py 92.30% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59a00a7...f0d48c2. Read the comment docs.

@scpeters scpeters merged commit 3b08d03 into main Jun 21, 2022
@scpeters scpeters deleted the scpeters/rename_joint_apis branch June 21, 2022 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants