Skip to content

Commit

Permalink
Suppress MSVC warning that is not applicable (#446)
Browse files Browse the repository at this point in the history
Signed-off-by: Michael Carroll <[email protected]>
(cherry picked from commit f2775ac)

# Conflicts:
#	include/gz/physics/FeatureList.hh
  • Loading branch information
mjcarroll authored and mergify[bot] committed Jul 10, 2024
1 parent 33bbf42 commit 226be35
Showing 1 changed file with 18 additions and 1 deletion.
19 changes: 18 additions & 1 deletion include/gz/physics/FeatureList.hh
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,21 @@

#include <gz/physics/Feature.hh>

<<<<<<< HEAD
namespace ignition
=======
#if defined(_MSC_VER)
#pragma warning(push)
/// Suppress warnings about "base-class is already a base-class"
/// Typically, this would indicate a diamond pattern in inheritance,
/// but there are uses in the plugin mechanism recursive templates.
/// The templates have no base classes, so there are no ambiguity
/// concerns, so we can safely suppress the warning here.
#pragma warning(disable: 4584)
#endif // defined(_MSC_VER)

namespace gz
>>>>>>> f2775ac (Suppress MSVC warning that is not applicable (#446))
{
namespace physics
{
Expand Down Expand Up @@ -111,4 +125,7 @@ namespace ignition

#include <gz/physics/detail/FeatureList.hh>

#endif
#if defined(_MSC_VER)
#pragma warning(pop)
#endif // defined(_MSC_VER)
#endif // GZ_PHYSICS_FEATURELIST_HH_

0 comments on commit 226be35

Please sign in to comment.