Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tutorial implement a physics plugin #128

Merged
merged 3 commits into from
Oct 22, 2020
Merged

Tutorial implement a physics plugin #128

merged 3 commits into from
Oct 22, 2020

Conversation

anindex
Copy link
Contributor

@anindex anindex commented Oct 11, 2020

Signed-off-by: anindex [email protected]

@anindex anindex requested a review from mxgrey as a code owner October 11, 2020 12:25
@anindex anindex changed the title Initial draft of implementing physics plugin tutorial Tutorial implement a physics plugin Oct 11, 2020
@chapulina chapulina added the documentation Improvements or additions to documentation label Oct 12, 2020
claireyywang
claireyywang reviewed Oct 16, 2020
View reviewed changes
Copy link
Contributor

@claireyywang claireyywang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general with some comments

tutorials/07-implementing-a-physics-plugin.md Outdated Show resolved Hide resolved
tutorials/07-implementing-a-physics-plugin.md Outdated Show resolved Hide resolved
tutorials/07-implementing-a-physics-plugin.md Outdated Show resolved Hide resolved
tutorials/07-implementing-a-physics-plugin.md Outdated Show resolved Hide resolved
tutorials/07-implementing-a-physics-plugin.md Show resolved Hide resolved
tutorials/07-implementing-a-physics-plugin.md Outdated Show resolved Hide resolved
@claireyywang claireyywang self-assigned this Oct 16, 2020
@claireyywang claireyywang mentioned this pull request Oct 16, 2020
Closed
claireyywang
claireyywang approved these changes Oct 22, 2020
View reviewed changes
Copy link
Contributor

@claireyywang claireyywang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@claireyywang claireyywang merged commit f16c92a into gazebosim:main Oct 22, 2020
claireyywang added a commit that referenced this pull request Jan 7, 2021
@anindex @claireyywang
Tutorial implement a physics plugin (#128)
bdc5c64 
* Initial draft of implementing physics plugin tutorial
* Resolve comments

Signed-off-by: anindex <[email protected]>

Co-authored-by: anindex <[email protected]>
Co-authored-by: Claire Wang <[email protected]>
chapulina pushed a commit that referenced this pull request Jan 21, 2021
@anindex @claireyywang @chapulina
Tutorial implement a physics plugin (#128)
33f87d3 
* Initial draft of implementing physics plugin tutorial
* Resolve comments

Signed-off-by: anindex <[email protected]>

Co-authored-by: anindex <[email protected]>
Co-authored-by: Claire Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claireyywang claireyywang claireyywang approved these changes

@mxgrey mxgrey Awaiting requested review from mxgrey

Assignees

@claireyywang claireyywang

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anindex @claireyywang @chapulina