Bump in edifice: sdformat11 #191
Conversation
Signed-off-by: Louise Poubel <[email protected]>
|
Trying a build with gazebo-tooling/release-tools#375 to see if all tests pass: Edit☝️ that was wrong, new one: |
| Using [TPE](https://github.com/ignitionrobotics/ign-physics/tree/main/tpe), | ||
| TPE directly sets model velocity in [VelocityControl.cc](https://github.com/ignitionrobotics/ign-gazebo/blob/ign-gazebo4/src/systems/velocity_control/VelocityControl.cc#L117) code. |
There was a problem hiding this comment.
note to self: check that these line numbers are still accurate
There was a problem hiding this comment.
they aren't, but I'll open an issue for that
Signed-off-by: Louise Poubel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #191 +/- ##
==========================================
+ Coverage 83.03% 83.11% +0.07%
==========================================
Files 106 106
Lines 3973 3973
==========================================
+ Hits 3299 3302 +3
+ Misses 674 671 -3
Continue to review full report at Codecov.
|
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
| @@ -117,7 +117,6 @@ static void CopyStandardJointAxisProperties( | |||
| const int _index, Properties &_properties, | |||
| const ::sdf::JointAxis *_sdfAxis) | |||
| { | |||
| _properties.mInitialPositions[_index] = _sdfAxis->InitialPosition(); | |||
There was a problem hiding this comment.
this is deprecated but still functional; so I would keep this line and suppress its deprecation warnings (currently there are test failures because this was removed)
There was a problem hiding this comment.
The test has been fixed. I followed the approach being taken on #189.
I can suppress the warning instead if that's preferred. I'm not sure if there's a new approach to use or if this feature will just disappear when we use SDF 12. SDFormat's migration guide didn't list any replacements. Are we sure we want to remove the feature?
CC @azeey
There was a problem hiding this comment.
I think the replacement may be using the <state> element, but until we've articulated that I'd like to keep the feature working, since it is only deprecated at this point, not disabled. I'll add a comment to that effect on #189 as well.
There was a problem hiding this comment.
I'll add a comment to that effect on #189 as well.
https://github.com/ignitionrobotics/ign-physics/pull/189/files#r558691120
There was a problem hiding this comment.
macro to suppress deprecation warnings in gazebosim/gz-utils#5
There was a problem hiding this comment.
Suppressing the warning in a more traditional style while this library doesn't depend on ign-utils yet. I'd like to merge this ASAP to unblock upstream.
Signed-off-by: Louise Poubel <[email protected]>
Addresses gazebo-tooling/release-tools#360