-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Ellipsoid and Capsule shapes to TPE #203
Conversation
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
088722e
to
6c4336f
Compare
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
I opened this PR for review, I can add more tests if required |
Codecov Report
@@ Coverage Diff @@
## ign-physics4 #203 +/- ##
================================================
+ Coverage 74.86% 75.26% +0.39%
================================================
Files 118 122 +4
Lines 5228 5376 +148
================================================
+ Hits 3914 4046 +132
- Misses 1314 1330 +16
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a draft for now, I need to include some more tests.
I wasn't sure about the status of this PR, so I went ahead and gave it a quick review. It's looking good to me, I think it would be nice to add tests to CollisionDetector_TEST
.
For future reference, I think it's also worth mentioning that TPE pretty much treats all shapes as boxes for the purpose of collision checking, because it only checks their AABBs. But Having these shapes supported means that worlds using complex shapes with other engines will work reasonably with TPE too.
The Homebrew and Ubuntu warnings are not introduced by this PR, but the Windows warnings are |
Signed-off-by: ahcorde <[email protected]>
@chapulina fixed windows warnings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I just have some minor final comments.
Signed-off-by: ahcorde <[email protected]>
…nitionrobotics/ign-physics into ahcorde/tpe/ellipsoid_capsule
Added ellipsoid and capsule to TPE. This PR builds on top of this other PR #202
Related with #196 and #195
It's a draft for now, I need to include some more tests.
Signed-off-by: ahcorde [email protected]