Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Windows instructions #242

Merged
merged 2 commits into from
Mar 30, 2021
Merged

Improved Windows instructions #242

merged 2 commits into from
Mar 30, 2021

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Mar 29, 2021

Signed-off-by: ahcorde [email protected]

🦟 Bug fix

Summary

Update example Windows instructions

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@ahcorde ahcorde requested a review from mxgrey as a code owner March 29, 2021 13:49
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Mar 29, 2021
@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #242 (7daf689) into main (f9641a5) will not change coverage.
The diff coverage is n/a.

❗ Current head 7daf689 differs from pull request most recent head 9afe90d. Consider uploading reports for the commit 9afe90d to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #242   +/-   ##
=======================================
  Coverage   82.39%   82.39%           
=======================================
  Files         109      109           
  Lines        4522     4522           
=======================================
  Hits         3726     3726           
  Misses        796      796           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9641a5...9afe90d. Read the comment docs.

@chapulina chapulina added documentation Improvements or additions to documentation Windows Windows support labels Mar 29, 2021
@chapulina chapulina self-requested a review March 29, 2021 16:11
examples/hello_world_loader/README.md Outdated Show resolved Hide resolved
@chapulina chapulina merged commit b108d92 into main Mar 30, 2021
@chapulina chapulina deleted the ahcorde/windows/doc branch March 30, 2021 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation 🏢 edifice Ignition Edifice Windows Windows support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants