Suggestion: Added basic architecture for common tests with cmd arguments #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <[email protected]>
9 tasks
Codecov Report
@@ Coverage Diff @@
## ahcorde/common_test_initial_commit #359 +/- ##
===================================================================
Coverage 74.55% 74.55%
===================================================================
Files 128 128
Lines 5628 5628
===================================================================
Hits 4196 4196
Misses 1432 1432 Continue to review full report at Codecov.
|
scpeters
reviewed
Jun 17, 2022
test/common_test/basic_test.cc
Outdated
| static std::string GetLibToTest() | ||
| { | ||
| return libToTest; | ||
| } |
There was a problem hiding this comment.
nit: tabs to spaces on the 2 lines above
test/common_test/CMakeLists.txt
Outdated
| add_test(NAME ${test_name}_${PHYSICS_ENGINE_NAME} | ||
| COMMAND | ||
| ${test_name} | ||
| ${CMAKE_BINARY_DIR}/lib/${CMAKE_SHARED_LIBRARY_PREFIX}${PROJECT_LIBRARY_TARGET_NAME}-${PHYSICS_ENGINE_NAME}-plugin${CMAKE_SHARED_LIBRARY_SUFFIX} |
There was a problem hiding this comment.
nit: use a generator expression to get the library file path from a target name
Signed-off-by: ahcorde <[email protected]>
…it' into ahcorde/common_test_initial_commit_cmd
…it' into ahcorde/common_test_initial_commit_cmd
chapulina
added
🌱 garden
scpeters
approved these changes
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ahcorde [email protected]
🎉 New feature
Summary
Use command line arguments to setup the physic engine library.
FYI @scpeters
Test it
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.