Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common test: Granular test #364

Merged
merged 31 commits into from
Jul 12, 2022
Merged

Common test: Granular test #364

merged 31 commits into from
Jul 12, 2022

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jun 23, 2022

🎉 New feature

Summary

This PR is related to this comment #360 (comment)

Add granular tests to allow be more useful as people are incrementally implementing a plugin.

FYI @scpeters

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ahcorde ahcorde self-assigned this Jun 23, 2022
Signed-off-by: ahcorde <[email protected]>
@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #364 (e6ca6eb) into main (6a507fb) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #364      +/-   ##
==========================================
+ Coverage   76.74%   76.77%   +0.03%     
==========================================
  Files         128      128              
  Lines        5628     5628              
==========================================
+ Hits         4319     4321       +2     
+ Misses       1309     1307       -2     
Impacted Files Coverage Δ
tpe/plugin/src/EntityManagementFeatures.cc 83.98% <0.00%> (-1.46%) ⬇️
bullet/src/EntityManagementFeatures.cc 12.58% <0.00%> (+3.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a507fb...e6ca6eb. Read the comment docs.

Copy link
Member

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this will provide earlier feedback to people implementing plugin features

there is a bit of duplication in the tests, but I'm not sure how that would be removed

Base automatically changed from ahcorde/6/refactor_common_test to main July 7, 2022 07:36
@ahcorde ahcorde marked this pull request as ready for review July 8, 2022 17:54
@ahcorde ahcorde requested review from azeey and mxgrey as code owners July 8, 2022 17:54
@ahcorde ahcorde merged commit 5758a45 into main Jul 12, 2022
@ahcorde ahcorde deleted the ahcorde/6/granular_test branch July 12, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants