Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure TPE related tutorials #419

Merged
merged 4 commits into from
Sep 21, 2022
Merged

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Sep 13, 2022

Signed-off-by: ahcorde [email protected]

🦟 Bug fix

Summary

For some reason two tutorials were merge in to 1, I don't know if this was intended.

Also fixed some code snippet visualizations

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: ahcorde <[email protected]>
@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #419 (0fc981e) into gz-physics6 (33d1a08) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           gz-physics6     #419   +/-   ##
============================================
  Coverage        73.69%   73.69%           
============================================
  Files              128      128           
  Lines             5787     5787           
============================================
  Hits              4265     4265           
  Misses            1522     1522           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ahcorde
Copy link
Contributor Author

ahcorde commented Sep 14, 2022

@scpeters or @azeey how do you feel about this ?

@azeey
Copy link
Contributor

azeey commented Sep 14, 2022

I think the tutorial was first added in #104 and then backported in #204. However, for some reason, the backport used a different file name (09_use_custom_engine.md) and a slightly different content. My guess is the tutorial was updated and the name changed to reflect the content of the tutorial and it was hoped it would be forward ported. However, since the file name changed, we ended up with two files after the forward port. My suggestion would be to to remove the 09_set-up-physics-engine-tpe.md since the other one looks more updated and seems more generic.

@ahcorde
Copy link
Contributor Author

ahcorde commented Sep 15, 2022

I think the tutorial was first added in #104 and then backported in #204. However, for some reason, the backport used a different file name (09_use_custom_engine.md) and a slightly different content. My guess is the tutorial was updated and the name changed to reflect the content of the tutorial and it was hoped it would be forward ported. However, since the file name changed, we ended up with two files after the forward port. My suggestion would be to to remove the 09_set-up-physics-engine-tpe.md since the other one looks more updated and seems more generic.

@azeey removed.

@ahcorde
Copy link
Contributor Author

ahcorde commented Sep 19, 2022

@azeey friendly ping

@ahcorde ahcorde merged commit 856e584 into gz-physics6 Sep 21, 2022
@ahcorde ahcorde deleted the ahcorde/fix/tpe_tutorials branch September 21, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants