Fix bullet cmake, probably bad merge #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nate Koenig <[email protected]>
Codecov Report
@@ Coverage Diff @@
## gz-physics6 #436 +/- ##
============================================
Coverage 73.69% 73.69%
============================================
Files 128 128
Lines 5787 5787
============================================
Hits 4265 4265
Misses 1522 1522 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
scpeters
approved these changes
Oct 7, 2022
scpeters
added a commit
that referenced
this pull request
Oct 8, 2022
Backport #436. Signed-off-by: Steve Peters <[email protected]>
|
back porting to fortress in #437 |
ahcorde
pushed a commit
that referenced
this pull request
Oct 10, 2022
Backport #436. Signed-off-by: Steve Peters <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nate Koenig [email protected]
🦟 Bug fix
Summary
gz-physics6fails to compile on windows because creating symlinks requires additional privileges. It looks like the bullet cmake file might have had a bad merge because there are duplicate lines outside theifblock. I've removed the lines in question.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.