Add tpelib::Shape::GetSize() and tpelib::Model::GetCanonicalLink() #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: claireyywang <[email protected]>
iche033
requested changes
Apr 29, 2020
| @@ -47,6 +47,8 @@ class IGNITION_PHYSICS_TPELIB_VISIBLE Model : public Entity | |||
| /// \return Newly created Link | |||
| public: Entity &AddLink(); | |||
|
|
|||
| public: Entity &GetCanonicalLink(); | |||
There was a problem hiding this comment.
can you add doxygen comment for this function?
There was a problem hiding this comment.
| @@ -84,6 +84,12 @@ void BoxShape::SetSize(const math::Vector3d &_size) | |||
| this->dirty = true; | |||
| } | |||
|
|
|||
| ////////////////////////////////////////////////// | |||
| math::Vector3d BoxShape::GetSize() | |||
There was a problem hiding this comment.
can you add a simple check here in Shape_TEST.cc to test this function?
There was a problem hiding this comment.
This was referenced Apr 29, 2020
Signed-off-by: claireyywang <[email protected]>
iche033
approved these changes
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tpelib::BoxShape::GetSize()was declared but not implemented in previous PR and caused windows CI failure intpe_pluginPRtpelib::Model::GetCanonicalLink()assumes the first link of each model is the canonical link, thus enabling ign-gazebo to find the link entity https://github.com/ignitionrobotics/ign-gazebo/blob/2259f027cd3a244f2c841b62c968088eace1b338/src/systems/physics/Physics.cc#L1233 and update world pose accordingly.This PR needs to be merged before #32