Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't install CMakeLists.txt files #456

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Dec 1, 2022

🦟 Bug fix

Fixes unstable debbuilds

Summary

The debbuilds from 2.6.0 are unstable due to some CMakeLists.txt files being accidentally installed.

This takes an approach similar to gazebosim/gz-common#449 to ensure that they aren't installed.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@scpeters scpeters requested review from azeey and mxgrey as code owners December 1, 2022 00:58
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Dec 1, 2022
@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Merging #456 (f2c7154) into ign-physics2 (f35c05d) will not change coverage.
The diff coverage is n/a.

❗ Current head f2c7154 differs from pull request most recent head 12de1ca. Consider uploading reports for the commit 12de1ca to get more accurate results

@@              Coverage Diff              @@
##           ign-physics2     #456   +/-   ##
=============================================
  Coverage         83.15%   83.15%           
=============================================
  Files               108      108           
  Lines              4210     4210           
=============================================
  Hits               3501     3501           
  Misses              709      709           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@scpeters scpeters merged commit 5e99521 into ign-physics2 Dec 1, 2022
@scpeters scpeters deleted the scpeters/uninstall_cmakelists branch December 1, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants