Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move joint transmitted wrench test to separate file #495

Merged
merged 2 commits into from
Mar 23, 2023

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Mar 22, 2023

🎉 New feature (sort of)

This moves the JointTransmittedWrenchFeaturesTest to a separate file. Nothing else was changed. This is a cleanup of #434.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

➡️ Forward port

Port <FROM_BRANCH> to <TO_BRANCH>

Branch comparison: https://github.com/gazebosim//compare/<TO_BRANCH>...<FROM_BRANCH>

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

🎈 Release

Preparation for <X.Y.Z> release.

Comparison to <x.y.z>: https://github.com/gazebosim//compare/<LATEST_TAG_BRANCH>...<RELEASE_BRANCH>

Needed by <PR(s)>

Checklist

  • Asked team if this is a good time for a release
  • There are no changes to be ported from the previous major version
  • No PRs targeted at this major version are close to getting in
  • Bumped minor for new features, patch for bug fixes
  • Updated changelog
  • Updated migration guide (as needed)
  • Link to PR updating dependency versions in appropriate repository in gazebo-release (as needed):

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #495 (f4267c0) into gz-physics6 (930a223) will decrease coverage by 0.55%.
The diff coverage is n/a.

❗ Current head f4267c0 differs from pull request most recent head c0c1c9c. Consider uploading reports for the commit c0c1c9c to get more accurate results

@@               Coverage Diff               @@
##           gz-physics6     #495      +/-   ##
===============================================
- Coverage        75.56%   75.02%   -0.55%     
===============================================
  Files              142      142              
  Lines             7191     7191              
===============================================
- Hits              5434     5395      -39     
- Misses            1757     1796      +39     

see 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scpeters scpeters merged commit adde787 into gz-physics6 Mar 23, 2023
@scpeters scpeters deleted the nkoenig/joint_wrench_separate_test branch March 23, 2023 07:35
scpeters added a commit that referenced this pull request Mar 23, 2023
Fix the test added in #495.

Signed-off-by: Steve Peters <[email protected]>
scpeters added a commit that referenced this pull request Mar 23, 2023
Fix the test added in #495.

Signed-off-by: Steve Peters <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants