Add a test to verify behavior of detachable joints #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reported bug was that the detachable joint was not correctly linked between objects' canonical links with bullet-featherstone. While this was addressed and confirmed working in #530, this adds a test to prevent future regression (or for future physics implementations) Signed-off-by: Michael Carroll <[email protected]>
Codecov Report
@@ Coverage Diff @@
## gz-physics6 #563 +/- ##
===============================================
+ Coverage 75.84% 75.95% +0.10%
===============================================
Files 143 143
Lines 7327 7327
===============================================
+ Hits 5557 5565 +8
+ Misses 1770 1762 -8 |
ahcorde
requested changes
Oct 24, 2023
| @@ -0,0 +1,202 @@ | |||
| /* | |||
| * Copyright (C) 2022 Open Source Robotics Foundation | |||
There was a problem hiding this comment.
Suggested change
| * Copyright (C) 2022 Open Source Robotics Foundation | |
| * Copyright (C) 2023 Open Source Robotics Foundation |
| { | ||
| gz::common::Console::SetVerbosity(4); | ||
|
|
||
| std::cerr << "DetachableJointTest::GetLibToTest() " << DetachableJointTest::GetLibToTest() << '\n'; |
There was a problem hiding this comment.
This is something we do in the other common tests:
Is there a reason to specifically remove it here?
iche033
approved these changes
Oct 30, 2023
ahcorde
approved these changes
Oct 30, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reported bug was that the detachable joint was not correctly linked between objects' canonical links with bullet-featherstone. While this was addressed and confirmed working in #530, this adds a test to prevent future regression (or for future physics implementations).
CC: @shameekganguly